trent
d1b8aa9230
All checks were successful
ci/woodpecker/pr/merge_to_master Pipeline was successful
(*) HeartBeatClient/Core/App.cs: Use DateTime.UtcNow instead of DateTime.Now for time calculations to avoid timezone issues. (*) HeartBeatClient/Core/App.cs: Add null check for configuration and vaultService injected parameters (defensive programming). (*) HeartBeatClient/Core/App.cs: Consider making Query strings constants readonly static fields to avoid reallocation. (*) HeartBeatClient/Core/App.cs: In UpdateHeartBeat, check for potential null 'result' to avoid possible null-forgiving operator misuse. (*) HeartBeatServer/Core/App.cs: In GetLastUpdateDate use 'await using' consistently inside using block, remove redundant results list by returning immediately. (*) HeartBeatServer/Core/App.cs: Prefer consistent naming of query constants and use const where appropriate. (*) HeartBeatServer/Core/App.cs: Use DateTime.UtcNow instead of DateTime.Now in InsertHeartBeat and UpdateHeartBeat for consistency and time zone safety. (*) EmailGeneratorService.cs: Add validation and more robust error handling especially for parsing SMTP port and missing/invalid configuration values. (*) EmailGeneratorService.cs: Dispose Attachments properly to avoid resource leaks. (*) Program.cs: Add more robust handling/validation if vault secrets are null or empty before using. (*) Minor: Avoid redundant namespace imports and empty interface code in ISmtpClientWrapperService.cs. Overall code is good but these improvements align better with best practices and make it more robust, safe, and maintainable.