Commit Graph

274 Commits

Author SHA1 Message Date
5fbeaac3e3 Merge pull request '* Extended GiteaSerive' (#62) from DelforSender into master
Reviewed-on: #62
2026-01-23 08:02:54 +00:00
ed0d01e924 * Extended GiteaSerive
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
* Added GiteaConfiguration
2026-01-23 09:02:11 +01:00
6215f1acbe Merge pull request '* Fixed registration issues' (#61) from DelforSender into master
Reviewed-on: #61
2026-01-23 07:42:32 +00:00
5c981f5c7d * Fixed registration issues
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-23 08:41:48 +01:00
b797d2a6d2 Merge pull request '* Changed MinVer to 2' (#60) from DelforSender into master
Reviewed-on: #60
2026-01-21 20:53:47 +00:00
ff0bb40028 * Changed MinVer to 2
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-21 21:53:26 +01:00
8f0d2dd59e Merge pull request '* Added MinVer to Services' (#59) from DelforSender into master
Reviewed-on: #59
2026-01-21 20:50:33 +00:00
c84923c01d * Added MinVer to Services
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-21 21:50:11 +01:00
1f9252d7e0 Merge pull request '* Added OpenAI service' (#58) from DelforSender into master
Reviewed-on: #58
2026-01-21 20:44:40 +00:00
ccb23dd7bf * Added OpenAI service
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-21 21:44:02 +01:00
258cf53b4b Merge pull request 'LLM: Code review suggestions' (#57) from code-review_j9v4sx2a into master
Reviewed-on: #57
2026-01-21 11:44:34 +00:00
d1c08efd7f LLM: Code review suggestions
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
* Use DateTime.UtcNow consistently instead of DateTime.Now to avoid timezone issues when comparing times.
* In App.cs, handle the scenario where HeartBeatInterval is 0 more explicitly to avoid incorrect alert generation.
* In App.cs, log or provide more informative error when HeartBeatInterval parsing fails.
* Add comments to clarify the logic regarding EmailSent flag usage.
* In Program.cs, change 'Builder' to 'HostBuilder' or clarify the Builder class usage; it seems unusual to name it 'Builder'.
* In Program.cs, the use of GetAwaiter().GetResult() can cause deadlocks in some scenarios; use async/await consistently.
* Add cancellation support in async methods if possible (not critical but recommended as best practice).
* Minor code style: consider using explicit class declaration instead of record-like primary constructor for App if more methods or fields are expected in the future.

These changes improve code clarity, robustness, and future maintainability.
2026-01-21 11:41:57 +00:00
6fd124d0fa Merge pull request '* Added Syncfusion license from vault' (#56) from DelforSender into master
Reviewed-on: #56
2026-01-21 11:35:58 +00:00
89510049db * Added Syncfusion license from vault
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-21 12:35:19 +01:00
748cd4c268 Merge pull request 'Code review suggestions:' (#55) from code-review_j4x9p6v2 into master
Reviewed-on: #55
2026-01-21 10:46:19 +00:00
add30fcc52 Code review suggestions:
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
* HeartBeatClient/Core/App.cs: Use DateTime.UtcNow instead of DateTime.Now for time comparison to avoid issues with time zones and daylight saving.
* HeartBeatClient/Core/App.cs: Simplify GetLastUpdateDate method by removing unnecessary list and returning single ResultModel directly.
* HeartBeatClient/Core/App.cs: Add null check after parsing heartBeatInterval to handle invalid configurations gracefully.
* HeartBeatClient/Core/App.cs: Consider injecting ILogger for proper logging instead of silent fallback to string.Empty for connection string.
* HeartBeatClient/Core/App.cs: Mark constants or magic strings as readonly static or move to configuration for easier management.
* HeartBeatClient/Program.cs: Use logging instead of Console.WriteLine for exception details to align with best practices in .NET apps.
* HeartBeatClient/Program.cs: Make sure Syncfusion license key is securely stored, e.g. environment variable or secure vault instead of hardcoded string.
* HeartBeatClient/Program.cs: Add ConfigureAwait(false) in awaited calls if library is used in non-UI context for performance.
2026-01-21 10:42:47 +00:00
a79e75a6ea Merge pull request '* Bugfixes' (#54) from DelforSender into master
Reviewed-on: #54
2026-01-21 10:35:57 +00:00
9924b3cdb3 * Bugfixes
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-21 11:35:29 +01:00
2ec4041f53 Merge pull request '* Implement changes from code review' (#53) from DelforSender into master
Reviewed-on: #53
2026-01-21 10:33:39 +00:00
c95d9d3f4c * Implement changes from code review
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
2026-01-21 11:33:01 +01:00
f4a018f9cc Merge pull request 'Code review suggestions:' (#52) from code-review_h3Jk9X2M into master
Reviewed-on: #52
2026-01-21 10:06:50 +00:00
0e38510e7a Code review suggestions:
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
* Add null checks and validations for configuration values to prevent exceptions if configuration is missing or invalid.
* Set IsBodyHtml property based on EmailModel to allow HTML emails.
* Dispose of attachments after sending the email to prevent resource leaks.
* Use asynchronous SendMailAsync method instead of synchronous Send to avoid blocking.
* Add exception handling for better resilience and logging opportunities.
* Validate email addresses before adding to avoid potential exceptions.
* Consider configuring EnableSsl based on configuration instead of hardcoding.

Changed file: HeartBeatClient/Services/EmailGeneratorService.cs
2026-01-21 10:05:19 +00:00
6f966d21ea Merge pull request '* Changed variable name' (#51) from DelforSender into master
Reviewed-on: #51
2026-01-21 09:27:26 +00:00
2968e0bf38 * Changed variable name
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-21 10:26:48 +01:00
b2ea7bc4f7 Merge pull request '* Added ChatBot to analyze file changes' (#50) from DelforSender into master
Reviewed-on: #50
2026-01-20 20:40:50 +00:00
e74576bda3 * Added ChatBot to analyze file changes
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-20 21:40:15 +01:00
3fabc9ef3f Merge pull request '* Fixed variable name' (#49) from DelforSender into master
Reviewed-on: #49
2026-01-20 12:45:03 +00:00
ce3e3e10ff * Fixed variable name
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-20 13:43:16 +01:00
57ee04f12c Merge pull request '* Changed variable name' (#48) from DelforSender into master
Reviewed-on: #48
2026-01-20 12:39:18 +00:00
93b3d1d8f5 * Changed variable name
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-20 13:38:55 +01:00
d772f70fa0 Merge pull request '* Pipeline changes' (#47) from DelforSender into master
Reviewed-on: #47
2026-01-20 12:33:21 +00:00
57d81473f2 * Pipeline changes
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-20 13:32:57 +01:00
517456f214 Merge pull request '* Changed PipelineAgent' (#46) from DelforSender into master
Reviewed-on: #46
2026-01-20 12:20:35 +00:00
2dca4c34ae * Changed PipelineAgent
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
* Changed variable name
2026-01-20 13:19:55 +01:00
5e7b353a90 Merge pull request '* Added missing nuget source' (#45) from DelforSender into master
Reviewed-on: #45
2026-01-20 12:13:40 +00:00
d3a54a477b * Added missing nuget source
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
2026-01-20 13:12:26 +01:00
18f510b268 Merge pull request 'DelforSender' (#44) from DelforSender into master
Reviewed-on: #44
2026-01-20 12:10:20 +00:00
aa4df43382 * Changed variable name
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
* Added PipelineAgent
2026-01-20 13:09:55 +01:00
e1389552c8 * Changed variable name 2026-01-20 13:08:40 +01:00
a31309547f Merge pull request 'DelforSender' (#43) from DelforSender into master
Reviewed-on: #43
2026-01-20 12:08:13 +00:00
faf90cf8a5 * Fixed issue with wrong step name
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-20 13:07:49 +01:00
1198babf08 * Changed step order 2026-01-20 13:07:08 +01:00
63ead2de67 Merge pull request '* Changed variable name' (#42) from DelforSender into master
Reviewed-on: #42
2026-01-20 12:02:57 +00:00
c2cf188e14 * Changed variable name
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-20 13:02:31 +01:00
6ff298677b Merge pull request '* Added missing check' (#41) from DelforSender into master
Reviewed-on: #41
2026-01-20 12:01:00 +00:00
35b87852a4 * Added missing check
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-20 13:00:37 +01:00
49d41081fd Merge pull request '* Added more checks for apps to process' (#40) from DelforSender into master
Reviewed-on: #40
2026-01-20 11:59:37 +00:00
4ac2616212 * Added more checks for apps to process
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
2026-01-20 12:59:14 +01:00
8aa3529572 Merge pull request '* Added missing dependencies' (#39) from DelforSender into master
Reviewed-on: #39
2026-01-20 11:46:00 +00:00
9eb26c046c * Added missing dependencies
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
2026-01-20 12:45:36 +01:00