748cd4c268
Merge pull request 'Code review suggestions:' ( #55 ) from code-review_j4x9p6v2 into master
...
Reviewed-on: #55
2026-01-21 10:46:19 +00:00
add30fcc52
Code review suggestions:
...
ci/woodpecker/pr/woodpecker Pipeline was successful
* HeartBeatClient/Core/App.cs: Use DateTime.UtcNow instead of DateTime.Now for time comparison to avoid issues with time zones and daylight saving.
* HeartBeatClient/Core/App.cs: Simplify GetLastUpdateDate method by removing unnecessary list and returning single ResultModel directly.
* HeartBeatClient/Core/App.cs: Add null check after parsing heartBeatInterval to handle invalid configurations gracefully.
* HeartBeatClient/Core/App.cs: Consider injecting ILogger for proper logging instead of silent fallback to string.Empty for connection string.
* HeartBeatClient/Core/App.cs: Mark constants or magic strings as readonly static or move to configuration for easier management.
* HeartBeatClient/Program.cs: Use logging instead of Console.WriteLine for exception details to align with best practices in .NET apps.
* HeartBeatClient/Program.cs: Make sure Syncfusion license key is securely stored, e.g. environment variable or secure vault instead of hardcoded string.
* HeartBeatClient/Program.cs: Add ConfigureAwait(false) in awaited calls if library is used in non-UI context for performance.
2026-01-21 10:42:47 +00:00
a79e75a6ea
Merge pull request '* Bugfixes' ( #54 ) from DelforSender into master
...
Reviewed-on: #54
2026-01-21 10:35:57 +00:00
9924b3cdb3
* Bugfixes
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-21 11:35:29 +01:00
2ec4041f53
Merge pull request '* Implement changes from code review' ( #53 ) from DelforSender into master
...
Reviewed-on: #53
2026-01-21 10:33:39 +00:00
c95d9d3f4c
* Implement changes from code review
ci/woodpecker/pr/woodpecker Pipeline failed
2026-01-21 11:33:01 +01:00
f4a018f9cc
Merge pull request 'Code review suggestions:' ( #52 ) from code-review_h3Jk9X2M into master
...
Reviewed-on: #52
2026-01-21 10:06:50 +00:00
0e38510e7a
Code review suggestions:
...
ci/woodpecker/pr/woodpecker Pipeline failed
* Add null checks and validations for configuration values to prevent exceptions if configuration is missing or invalid.
* Set IsBodyHtml property based on EmailModel to allow HTML emails.
* Dispose of attachments after sending the email to prevent resource leaks.
* Use asynchronous SendMailAsync method instead of synchronous Send to avoid blocking.
* Add exception handling for better resilience and logging opportunities.
* Validate email addresses before adding to avoid potential exceptions.
* Consider configuring EnableSsl based on configuration instead of hardcoding.
Changed file: HeartBeatClient/Services/EmailGeneratorService.cs
2026-01-21 10:05:19 +00:00
6f966d21ea
Merge pull request '* Changed variable name' ( #51 ) from DelforSender into master
...
Reviewed-on: #51
2026-01-21 09:27:26 +00:00
2968e0bf38
* Changed variable name
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-21 10:26:48 +01:00
b2ea7bc4f7
Merge pull request '* Added ChatBot to analyze file changes' ( #50 ) from DelforSender into master
...
Reviewed-on: #50
2026-01-20 20:40:50 +00:00
e74576bda3
* Added ChatBot to analyze file changes
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-20 21:40:15 +01:00
3fabc9ef3f
Merge pull request '* Fixed variable name' ( #49 ) from DelforSender into master
...
Reviewed-on: #49
2026-01-20 12:45:03 +00:00
ce3e3e10ff
* Fixed variable name
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-20 13:43:16 +01:00
57ee04f12c
Merge pull request '* Changed variable name' ( #48 ) from DelforSender into master
...
Reviewed-on: #48
2026-01-20 12:39:18 +00:00
93b3d1d8f5
* Changed variable name
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-20 13:38:55 +01:00
d772f70fa0
Merge pull request '* Pipeline changes' ( #47 ) from DelforSender into master
...
Reviewed-on: #47
2026-01-20 12:33:21 +00:00
57d81473f2
* Pipeline changes
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-20 13:32:57 +01:00
517456f214
Merge pull request '* Changed PipelineAgent' ( #46 ) from DelforSender into master
...
Reviewed-on: #46
2026-01-20 12:20:35 +00:00
2dca4c34ae
* Changed PipelineAgent
...
ci/woodpecker/pr/woodpecker Pipeline was successful
* Changed variable name
2026-01-20 13:19:55 +01:00
5e7b353a90
Merge pull request '* Added missing nuget source' ( #45 ) from DelforSender into master
...
Reviewed-on: #45
2026-01-20 12:13:40 +00:00
d3a54a477b
* Added missing nuget source
ci/woodpecker/pr/woodpecker Pipeline failed
2026-01-20 13:12:26 +01:00
18f510b268
Merge pull request 'DelforSender' ( #44 ) from DelforSender into master
...
Reviewed-on: #44
2026-01-20 12:10:20 +00:00
aa4df43382
* Changed variable name
...
ci/woodpecker/pr/woodpecker Pipeline failed
* Added PipelineAgent
2026-01-20 13:09:55 +01:00
e1389552c8
* Changed variable name
2026-01-20 13:08:40 +01:00
a31309547f
Merge pull request 'DelforSender' ( #43 ) from DelforSender into master
...
Reviewed-on: #43
2026-01-20 12:08:13 +00:00
faf90cf8a5
* Fixed issue with wrong step name
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-20 13:07:49 +01:00
1198babf08
* Changed step order
2026-01-20 13:07:08 +01:00
63ead2de67
Merge pull request '* Changed variable name' ( #42 ) from DelforSender into master
...
Reviewed-on: #42
2026-01-20 12:02:57 +00:00
c2cf188e14
* Changed variable name
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-20 13:02:31 +01:00
6ff298677b
Merge pull request '* Added missing check' ( #41 ) from DelforSender into master
...
Reviewed-on: #41
2026-01-20 12:01:00 +00:00
35b87852a4
* Added missing check
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-20 13:00:37 +01:00
49d41081fd
Merge pull request '* Added more checks for apps to process' ( #40 ) from DelforSender into master
...
Reviewed-on: #40
2026-01-20 11:59:37 +00:00
4ac2616212
* Added more checks for apps to process
ci/woodpecker/pr/woodpecker Pipeline failed
2026-01-20 12:59:14 +01:00
8aa3529572
Merge pull request '* Added missing dependencies' ( #39 ) from DelforSender into master
...
Reviewed-on: #39
2026-01-20 11:46:00 +00:00
9eb26c046c
* Added missing dependencies
ci/woodpecker/pr/woodpecker Pipeline failed
2026-01-20 12:45:36 +01:00
cb2975561e
Merge pull request '* Fixed wrong exit instruction' ( #38 ) from DelforSender into master
...
Reviewed-on: #38
2026-01-20 11:42:55 +00:00
5e4407fed0
* Fixed wrong exit instruction
ci/woodpecker/pr/woodpecker Pipeline failed
2026-01-20 12:42:33 +01:00
8da2ba4676
Merge pull request '* Changed pipeline to break/return success when there is no projects changed' ( #37 ) from DelforSender into master
...
Reviewed-on: #37
2026-01-20 11:41:25 +00:00
cd194c9eba
* Changed pipeline to break/return success when there is no projects changed
ci/woodpecker/pr/woodpecker Pipeline failed
2026-01-20 12:40:58 +01:00
7c87bb9cd5
Merge pull request '* Removed not needed lines' ( #36 ) from DelforSender into master
...
Reviewed-on: #36
2026-01-20 11:05:33 +00:00
ec81381e5c
* Removed not needed lines
ci/woodpecker/pr/woodpecker Pipeline failed
2026-01-20 12:05:10 +01:00
6612facffe
Merge pull request '* Fixed loop issue' ( #35 ) from DelforSender into master
...
Reviewed-on: #35
2026-01-20 11:02:55 +00:00
1bb8e1ecb2
* Fixed loop issue
2026-01-20 12:02:32 +01:00
438a7c0b6e
Merge pull request '* Further changes to steps in pipeline to use only changed projects' ( #34 ) from DelforSender into master
...
Reviewed-on: #34
2026-01-20 10:55:35 +00:00
f1b8e47fd3
* Further changes to steps in pipeline to use only changed projects
2026-01-20 11:50:44 +01:00
2ae38eeb72
Merge pull request '* Changed detecting projects from json list to raw one' ( #33 ) from DelforSender into master
...
Reviewed-on: #33
2026-01-20 10:47:14 +00:00
c98e8c2c14
* Changed detecting projects from json list to raw one
ci/woodpecker/pr/woodpecker Pipeline was successful
2026-01-20 11:46:42 +01:00
e69f6ac1c4
Merge pull request '* Added step to detect projects which have been changed' ( #32 ) from DelforSender into master
...
Reviewed-on: #32
2026-01-20 10:41:23 +00:00
589837ea6c
* Added step to detect projects which have been changed
ci/woodpecker/pr/woodpecker Pipeline failed
2026-01-20 11:40:43 +01:00
